Implement optional groups #3531
Conversation
* Add optional option to the group method, defaulting to false * Exclude optional groups from the groups to be installed * Add --with parameter to bundle install to install a group that would * otherwise be excluded * Error out if a group is listed in both, --with and --without * Add bundle_with option to capistrano task
| @@ -151,6 +151,8 @@ def check | |||
| Bundler.rubygems.security_policy_keys.join('|') | |||
| method_option "without", :type => :array, :banner => | |||
| "Exclude gems that are part of the specified named group." | |||
| method_option "with", :type => :array, :banner => | |||
| "Include gems that are part of the specified named group." | |||
There was a problem hiding this comment.
We should probably say "specified optional group" here, to make it clear that with only applies to optional groups.
There was a problem hiding this comment.
I thought about that but actually it does not only apply to optional groups. Applying it to a normal group has no effect but also doesn't throw an error, however applying it to a normal group that was previously excluded with without, removes it from the excluded groups.
There was a problem hiding this comment.
Yeah, that makes sense. I read the rest of the diff after I made that comment. :)
There was a problem hiding this comment.
I did most reasoning in rubygems/bundler-features#68, which is why I spared it in the PRs description :)
|
This looks like the most reasonable implementation of How do you feel about this change, @bundler/core? |
|
👍 thanks @jhass! |
|
Alright, anything else you need from my side? |
|
Don't think so! Was just waiting for consensus from the core team and haven't had time to circle back around to this pull yet. Thanks! |
|
<3 Thanks! I know, annoying question, but any rough ETA on when I can see this in a release? |
|
I'd like to publish a prerelease within the next week, and then the final will be a week or two after all the known bugs are worked out. On Tue, Apr 7, 2015 at 11:25 AM, Jonne Haß notifications@github.com
|
|
Awesome news, thanks! |
|
The advantage of the The The shift in control is subtle but I think the |
|
@rymohr +1 |
The lack of discussion in rubygems/bundler-features#68 and rubygems/bundler-features#59 is depressing, so here's some meat to get things going, hopefully.